Uploaded image for project: 'NHibernate [Moved to GitHub]'
  1. NH-2950

Update optimizers for enhanced id generators (ported from Hibernate)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0.GA
    • Fix Version/s: 3.3.0.CR1
    • Component/s: Core
    • Labels:
    • Sprint:

      Description

      The updates to the optimizers are now ready for review and hopefully merge.
      Pull request: https://github.com/nhibernate/nhibernate-core/pull/26

      Details:
      I have ported most of the changes made to the enhanced id generator's
      optimizers since Fabio's initial port in 2008:

      Notably this adds the PooledLoOptimizer and fixes concurrency issues
      in several optimizers. Tests are also ported (previously missing).

      I also change IAccessCallback.NextValue to be a method instead, to
      follow what Microsoft's guidelines say about property getters free
      from side effects.

      I have not included the LegacyHiloGenerator, as I'm unsure what
      "legacy" refers to and if it's needed in NH. It can be added later if
      there is interest.

      I intend to finish porting the enhanced TableGenerator also, but I
      figured I should submit this smaller part first, for easier review.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              oskar.berggren Oskar Berggren
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Who's Looking?