Query Cache does not support Batch Loading using batch-size

Please provide a test case.

I would like to see a behavior test to understand better if it is a real bug or an expected behavior.
Scheduled to study it more deep in next mayor version.

After spending some more time reviewing SVN logs, I have a simpler fix.

Just change the default value of ManyToOneType's eager field. I was hesitant to do this in the beginning, but now I believe that the current version may have been a mistake.

Here's my rationale:

in revision 2453, justme84 implemented https://nhibernate.jira.com/browse/NH-795#icft=NH-795 - lazy="proxy|false" for associations.

It appears that the whole purpose of this revision was to enable an explicit lazy="proxy" attribute in <many-to-one>

This involved adding an "eager" parameter to SessionImpl.InternalLoad (a method that is only used by AnyType and EntityType for assembling and resolving identifiers)

Before this revision, the default behavior of SessionImpl.InternalLoad was to create proxies for everything (that was nullable).

After this revision:

the eager parameter in SessionImpl.InternalLoad explicitly enables or disables proxy creation
AnyType continues to exhibit the previously default behavior by explicitly specifying eager=false whenever it invokes SessionImpl.InternalLoad
But ManyToOneType effectively reverses the previous default
it passes its eager field to SessionImpl.InternalLoad
But eager will now almost always be true, because ManyToOneType sets lazy=false (and therefore eager=true) in the constructor ManyToOneType(Type persistentClass).
Since that particular constructor is used by NHibernateUtils.Entity() and TypeFactory.ManyToOne(), this effectively propogates the change all over the place.

So, I think this revision accidentally switched the default proxying behavior for ManyToOneType.

It seems to me that NH should always default to returning proxies unless explicitly disabled. It's further supported by the following facts:

The default value for IsLazy in NHibernate.Mapping.ToOne (and therefore OneToOne and ManyToOne) is true
AnyType still defaults to eager=false

So I'm uploading a different patch where I only changed 2 lines of code in 2 files. It also passes all the NH unit tests.

If I get some downtime in my project I'll try to write a test case for the batching stuff.

Ok I've created a patch that appears to solve the problems and also passes all the NH tests.

The patch was derived from this svn path:

https://nhibernate.svn.sourceforge.net/svnroot/nhibernate/tags/1.2.1.GA/nhibernate.

Basically I tweaked the construction of the ManyToOneType in the following places:

QueryTranslator - for cached HQL statements to batch load the returned entities
NHibernate.Tuple.EntityMetamodel - for cached HQL statements with scalar entities to batch load those entities
CriteriaJoinQalker - for cached Criteria queries to batch load the returned entities
NHibernate.Mapping.OneToMany - for cached collections to batch load returned entities

I've confirmed that cached collections have the same problem.