Change signature of AbstractPersistentCollection.IdentityRemoveAll() from ICollection to IEnumerable for generics

Description

The following should be done:

Currently signature of the AbstractPersistentCollection.IdentityRemoveAll() method looks like this:

My suggestion is to change ICollection to IEnumerable:

Why:

The method is implemented in the following way, note that there is no need for ICollection here:

and it is called by the classes like PersistentGenericList, Bag, etc. in the following way:

I'm trying to define my custom collection class and as result getting the following error:

Changing the above method to:

and using in the PersistentGenericList as:

solves the problem.

Please Refacotor > Change Signature someone and commit it.

Environment

None

Activity

Show:

Fabio Maulo June 16, 2008 at 8:03 AM

Take a look on trunk; the NHibernate.Collection name space was rewritten.

GennadiiG May 9, 2008 at 4:52 PM

.... looks like another Improvement request should be assigned to JIRA component:

  • enable {code} macro

So that code will be formatted here

Won't Fix

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Who's Looking?

Open Who's Looking?
Created May 9, 2008 at 4:50 PM
Updated June 16, 2008 at 8:03 AM
Resolved June 16, 2008 at 8:03 AM
Who's Looking?