Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

AbstractEntityPersister.Delete is not virtual

Description

i went to implement some custom delete functionality in my project by creating a custom entity persister which inherited from JoinedSubclassEntityPersister. However i couldn't because there was no extensibility point.

I noticed that allthough in AbstractEntityPersister GenerateInsertString, GenerateUpdateString, and most (if not all) of the other similar methods were virtual. However GenerateDeleteString was not.

so i have submitted this patch which makes GenerateDeleteString(int j) virtual.

i would be really glad if it could be applied soon. i don't see any way in which it could break anything
(i have marked this task critical because we cannot release our product without it - and i don't want to use a patched version of nhibernate)

thanks

Environment

None

Attachments

1

Activity

Show:

Matthew Fenner 
June 10, 2009 at 7:13 PM

sorry. i was trying to keep the description short.

i have been discussing it here already:
http://groups.google.com/group/castle-project-users/browse_thread/thread/4cfafca734eb89a4

Fabio Maulo 
June 10, 2009 at 7:38 AM

"i have marked this task critical because we cannot release our product without it"
but the subject here is NHibernate.

Make that method virtual is not a problem but I'm not so sure you are walking the right way.
Would be nice if you share your experience and which is the problem solved with your custom persister (in some place, perhaps the wiki in NH-Forge or in some blog).

Matthew Fenner 
June 10, 2009 at 3:58 AM

patch uploaded

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Who's Looking?

Open Who's Looking?
Created June 10, 2009 at 3:56 AM
Updated July 22, 2009 at 7:21 AM
Resolved June 10, 2009 at 7:47 AM
Who's Looking?