NHibernate.Engine.QueryParameters.ValidateParameters doesn't do anything.

The ternary conditional operators in ValidateParameters is coded incorrectly and thus does nothing. The ternary is "test" ? "true" : "false", but what is coded is the opposite; the != null should be a == null.

public void ValidateParameters()
{
int typesLength = PositionalParameterTypes != null ? 0 : PositionalParameterTypes.Length;
int valuesLength = PositionalParameterValues != null ? 0 : PositionalParameterValues.Length;

if( typesLength != valuesLength )
{
throw new QueryException( "Number of positional parameter types (" + typesLength + ") does not match number of positional parameter values (" + valuesLength + ")" );
}
}

SHOULD BE:

public void ValidateParameters()
{
int typesLength = PositionalParameterTypes == null ? 0 : PositionalParameterTypes.Length;
int valuesLength = PositionalParameterValues == null ? 0 : PositionalParameterValues.Length;

if( typesLength != valuesLength )
{
throw new QueryException( "Number of positional parameter types (" + typesLength + ") does not match number of positional parameter values (" + valuesLength + ")" );
}
}