Batcher for MySql

Description

Hi,

Few months ago I found that there is no way to do bulk updates for MySql in NHibernate.
After few days of using Reflector on both NHibernate and MySql data provider, I realised that implementing this feature shoudln't be hard.

Please, have a look at the patch attached.
I created it using trunk rev. 5972. Besides code changes, it also requires MySql.Data.dll.
It should work with any version of MySql.Data.dll greater than 5.2.3.0 (at least).

I assume, that having a reference to MySql.Data.dll in the NHibernate solution file is probably the biggest question, and, maybe, the actual reason why this batcher wasn't implemented before. I'm open to any discussion re this matter.

Looking forward to your response.

Environment

None

Attachments

1

Activity

Show:

Frédéric Delaporte August 2, 2017 at 4:16 PM

Was it decided on purpose not to have the MySql driver supply the batcher itself? This causes the batcher to be unused unless explicitly configured with adonet.factory_class setting (which name is not really explicit about what usage it has).

Alex Zaytsev August 3, 2012 at 3:42 PM

Commited to master bce3ea53d017d6ceda7e79b9105ab70970701fba

Alex Zaytsev August 3, 2012 at 3:41 PM

Yes. There was three unnecessary casts.

Oleg Sakharov August 3, 2012 at 3:00 PM

@Alexander Did you make to compile without it?

Alex Zaytsev August 3, 2012 at 2:56 PM

I do not see any reasons to reference MySql.Data.dll in your code.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Who's Looking?

Open Who's Looking?

Created June 27, 2011 at 3:18 PM
Updated August 2, 2017 at 4:16 PM
Resolved August 3, 2012 at 3:42 PM
Who's Looking?