There is a large change that's over 5 months old for which is on master but not on the 3.x.x branches. Presumably, this was not included in 3.x.x for a reason but it is a blocker for my project as our DBAs were counting on autoComment as a bridge from using named sprocs for CRUD operations. This change radically changes the entire MsSql2005DialectQueryPager.cs class in what appears to be a positive way. Unfortunately, because the change is fairly large and is such a major refactor it's tough to pull into a custom dialect and I don't want to cherry-pick it (which appears to be non-trivial) without some assurance that it's ultimately going to be pulled into a release. Could someone either pull it into a 3.x branch or add a comment to explaining why it's been held out? I can create a pull request for the move if that makes sense but obviously we don't want to if there's a fundamental problem with the code that led to its omission.
I wound up having to cherry-pick two commits (27e0f269c08cdd71f753f8d4d14ee542a4294aef () and bd01c71952c16f8ae9ca0b5f0ab74cedf12fa2e1 ()). The commit comment isn't quite right. I also added two additional unit tests.
Oskar Berggren
March 10, 2013 at 9:20 AM
I would prefer to avoid more changes to 3.3.3 except regression fixes - it's been too long already.
If you submit code, we can consider a simple change for a tentative 3.3.4 or 3.4. (And you can use the simple fix in a private branch temporarily.) I you want to port the bigger patch, we could maybe have it in a 3.4. (Nothing has been decided, but there seems to be more and more reasons to do a 3.4 for those not ready for Net4.0.)
See nhusers thread here: https://groups.google.com/forum/?fromgroups=#!topic/nhusers/xJ675yG2uhY
There is a large change that's over 5 months old for which is on master but not on the 3.x.x branches. Presumably, this was not included in 3.x.x for a reason but it is a blocker for my project as our DBAs were counting on autoComment as a bridge from using named sprocs for CRUD operations. This change radically changes the entire MsSql2005DialectQueryPager.cs class in what appears to be a positive way. Unfortunately, because the change is fairly large and is such a major refactor it's tough to pull into a custom dialect and I don't want to cherry-pick it (which appears to be non-trivial) without some assurance that it's ultimately going to be pulled into a release. Could someone either pull it into a 3.x branch or add a comment to explaining why it's been held out? I can create a pull request for the move if that makes sense but obviously we don't want to if there's a fundamental problem with the code that led to its omission.