Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

MsSql2012Dialect does not create sequence datatype based on the defined datatype in the IdentifierGenerator

Description

The MsSql2012Dialect always uses an int as the datatype for a given sequence. The comment in the code does state bigint as the datataype. When using an bigint/long as identifier the datatype of the created sequence should be of the same type.

Current implementation:

protected override string GetCreateSequenceString(string sequenceName, int initialValue, int incrementSize) { // by default sequence is created as bigint return string.Format("create sequence {0} as int start with {1} increment by {2}", sequenceName, initialValue, incrementSize); }

Makeshift (hard-coded) fix:

public class MsSql2012CustomDialect : MsSql2012Dialect { protected override string GetCreateSequenceString(string sequenceName, int initialValue, int incrementSize) { return string.Format("create sequence {0} as bigint start with {1} increment by {2}", sequenceName, initialValue, incrementSize); } }

Environment

Microsoft SQL Server 2012

Activity

Show:

Alex Zaytsev February 21, 2017 at 7:50 AM

Moving to the improvement rather than a bug.

Alex Zaytsev February 21, 2017 at 7:48 AM

Comment is correct: the default type for sequences according to MSDN is bigint.

However, bigint is probably the type we want, at least, every other dialect with sequences does not specify the data type, and, I believe, in majority of them the type would be equal to bigint.

Details

Assignee

Reporter

Components

Affects versions

Priority

Who's Looking?

Open Who's Looking?

Created February 20, 2017 at 6:01 PM
Updated February 21, 2017 at 7:50 AM
Who's Looking?