Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SqlClientBatchingBatcher CloseCommands contract violated

Description

CloseCommands xml comment states:

/// Use this method instead of <c>Dispose</c> if the <see cref="IBatcher"/> /// can be used again.

But SqlClientBatchingBatcher dispose there a ressource without replacing it with a new one, causing the batcher to be unusable.

This causes a failure in a https://nhibernate.jira.com/browse/NH-2176#icft=NH-2176 ongoing PR, where it uses CloseCommands in an additional case.

This may causes issues to users with NHibernate 4.1 when they happen to trigger following code in ConnectionManager:

else if (IsAggressiveRelease && _batcher.HasOpenResources) { _log.Info("Forcing batcher resource cleanup on transaction completion; forgot to close ScrollableResults/Enumerable?"); _batcher.CloseCommands(); AggressiveRelease(); }

Environment

None

Activity

Show:

Frédéric Delaporte May 20, 2017 at 4:21 PM

Same trouble for MySql.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Who's Looking?

Open Who's Looking?

Created May 20, 2017 at 3:34 PM
Updated June 8, 2017 at 10:39 AM
Resolved June 8, 2017 at 10:38 AM
Who's Looking?