Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Handle Time parameter conversion for newer Npgsql

Description

Npgsql has change it DbType.Time handling in it v3 series. (See #347.) It was mapping it to DateTime prior to v3, it now maps it to TimeSpan.

It was supposed to handle conversion from DateTime to TimeSpan and is even documented as such, but in NHibernate use cases, it fails (sending a DbCommand with a DbType.Time parameter having a DateTime value).

It appears NHibernate already does a DateTime to TimeSpan conversion for SQL Server 2008 and above. So we just have to take that. Excepted we should probably do that conversion only if the loaded Npgsql is v3 or above...

Environment

None

Activity

Show:

Frédéric Delaporte May 26, 2017 at 3:52 PM

I have added the condition on loaded Npgsql version anyway, just to really be on the safe side.

Alex Zaytsev May 25, 2017 at 7:51 PM

I did not check the GitHub, just checking emails eventually

Frédéric Delaporte May 25, 2017 at 7:31 PM
Edited

Why not. Already done in a PR on current driver while still using Npgsql 2, it looks like it supports it. That is why I have flagged this as "possible breaking change" rather than "breaking change". I have not checked current tests are strong enough for their success to be a very good indicator of support.

And instead of introcuding a new driver, if it was needed to not do the conversion for older version, I was envisioning getting the Npgsql assembly version and do the conversion only if >= 3. This way, no need to adjust the driver in configuration according to the used Npgsql version.

Alex Zaytsev May 25, 2017 at 7:06 PM
Edited

Are you going to do this conversion on a driver level? I think if it is, then it worth to make a separate Npgsql3Driver. This way it should not be a breaking change.

Frédéric Delaporte May 25, 2017 at 7:03 PM

TimeAsTimeSpan and the like are for choosing the resulting .Net type on the entity, regardless of the default .Net type mapping of the provider.

Here, that does change the .Net type internally used by NHibernate for sending parameters values to the provider.

Both Time and TimeAsTimeSpan tests were failing with Npgsql 3, because both types supply parameters values for entity updates and inserts as DateTime. The change convert those parameters values to TimeSpan, as it is already done by Sql2008ClientDriver.

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

Who's Looking?

Open Who's Looking?

Created May 25, 2017 at 3:45 PM
Updated June 2, 2017 at 10:31 AM
Resolved June 2, 2017 at 10:31 AM
Who's Looking?