Complete keyword registration needs done in dialects.
Description
This is a dependency of NH-3807.
So implemented IDataBaseSchema.GetReservedWords(). Unfortunately, it relies on DbConnection.GetSchema() which throws a NotSupportedException on .NET Core platforms.
We can use the full .NET Framework's continued use of DbConnection.GetSchema() through a test that checks that the Dialects are up to date.
The existing test, SchemaMetadataUpdaterFixture.UpdateReservedWordsInDialect() appears at first glance in its name that it intends to check that the dialects are up to date with their keywords, but as far as I can tell, it really just checks that IDataBaseSchema.GetReservedWords() can get called twice and returns the same thing each time.
New tests are needed, and will check that the Dialect's keyword list is complete with what is returned by the database drivers in full .NET Framework. The metadata for possible Types should be included as well (DbMetaDataCollectionNames.DataTypes).
Environment
.NET Standard / .NET Core on Windows / Linux / macOS
The registration of keywords could be improved by the way. It currently takes any casing and stores keywords in case-sensitive set. But the matching is done against lower-case tokens, causing any keyword registered without being fully lower-case to be useless. Either the set should be changed for being case-insensitive, or the keyword registration should lower case keywords before adding them.
This is a dependency of NH-3807.
So implemented
IDataBaseSchema.GetReservedWords(). Unfortunately, it relies onDbConnection.GetSchema()which throws aNotSupportedExceptionon .NET Core platforms.We can use the full .NET Framework's continued use of
DbConnection.GetSchema()through a test that checks that the Dialects are up to date.The existing test,
SchemaMetadataUpdaterFixture.UpdateReservedWordsInDialect()appears at first glance in its name that it intends to check that the dialects are up to date with their keywords, but as far as I can tell, it really just checks thatIDataBaseSchema.GetReservedWords()can get called twice and returns the same thing each time.New tests are needed, and will check that the Dialect's keyword list is complete with what is returned by the database drivers in full .NET Framework. The metadata for possible Types should be included as well (
DbMetaDataCollectionNames.DataTypes).