JetDriver: Missing parenthesis in subqueries

great news!!! thanks!

Okay as far as for this bug goes, it is reproduced and fixed. Basically second select statements were not processed at all by jet dialect so there may still be some edge cases. Thanks for reporting the bug and following it up.

One correction about the last query above:

from Catalog c
join c.Category as cat
join c.ProductType as pt
join cat.Product as p
where p.id NOT IN (select pi.id from Catalog ci
join ci.Category as cati
join ci.ProductType as pti
join cati.Product as pi)

Hadi, I think you didn't get my point.

Your query is OK, but it won't reproduce the issue... To reproduce the issue, your query should be something like:

from Catalog c
join c.Category as cat
join c.ProductType as pt
join cat.Product as p
where c.Category.Name NOT IN ( select cg.Name from Category cg <join something else here, two joins required to make it fail, wou will notice no parenthesis in the inner query> )

You see? The Subquery inside the NOT IN clause shoulg have more than one join (to force the need of parenthesis in the generated SQL) to fail.

maybe, something like the following query helps:

from Catalog c
join c.Category as cat
join c.ProductType as pt
join cat.Product as p
where c NOT IN (select c from Catalog ci
join c.Category as cati
join c.ProductType as pti
join cat.Product as pi)

The query is useless but it will fail. You will notice NO parenthesis in the generated SQL subquery.

By the way, if you upgrade to build of the truck, it still uses NHibernate 2.1.0.4000. We plan to provide new build for NHibernate 2.1.2 GA and I'll try to provide official download link from the SourceForge.